question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Minor UI change for Monetization CTR on Unified Dashboard

See original GitHub issue

Bug Description

A very minor UI change - on Unified Dashboard, the Monetization CTR has a title Connect Service which is styled differently than other connect service CTRs. As you can see in the screenshot below, the title is in upper case and slightly smaller font size. Would be good to have it consistent.

image

image


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The treatment of the “Connect Service” text/header of the AdSenseConnectCTA should be consistent with the similar interface for module setup, particularly:
    • Font size and case
    • Margin
    • Letter spacing
Screenshots

Current image

Target image

Note the lack of margin-top here as well

Implementation Brief

  • In assets/sass/components/setup/_googlesitekit-setup.scss.
    • Define .googlesitekit-setup__wrapper class inside the .googlesitekit-plugin class but outside the .googlesitekit-setup class.
    • Move the .googlesitekit-setup__intro-title class with all its properties from .googlesitekit-setup to the newly added .googlesitekit-setup__wrapper class.

Test Coverage

  • VRTs may need to be updated.

QA Brief

  • QAing this would require checking the Modules -> AdSense -> Widgets -> AdSenseConnectCTA -> Ready story and making sure the “Connect Service” heading looks like the other similar CTAs.
  • You can use the screenshots in AC for reference.

Changelog entry

  • N/A

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:6

github_iconTop GitHub Comments

1reaction
wpdarrencommented, May 23, 2022

QA Update: ✅

  • Checked Storybook AdSenseConnectCTA story and the “Connect Service” heading looks like the other similar CTAs.
  • Set up a test site and can confirm that on the Site Kit Dashboard, the AdSense CTA is styled as per the screenshot in AC.

image

1reaction
eclarke1commented, Apr 6, 2022

@kuasha420 please could you add an estimate to this one, thanks

Read more comments on GitHub >

github_iconTop Results From Across the Web

About changes between Meta Business Suite and ... - Facebook
Here are some changes you can expect to see in Meta Business Suite if you use ... Unified Inbox: Read new messages and...
Read more >
Using the Security Command Center dashboard - Google Cloud
This page explains how to access Security Command Center in the Google Cloud console, configure the display, and review your findings and Google...
Read more >
2022 Google Ad Manager releases archive
2022 Google Ad Manager releases archive · New pricing rules for video creatives · Expansion of policy violation screenshots · View performance insights...
Read more >
How to Customize Your Google Analytics Dashboard
Customizing the Google Analytics dashboard can provide you with a wealth of new insights to help you monetize your site. Check out our...
Read more >
Top Facebook Updates You Can't Miss (November 2022 ...
Facebook and Instagram accounts that are connected through the Account Center, however, will still be counted as a single user. This update will ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found