Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

TimeoutError in GTM setup E2E test

See original GitHub issue

Bug Description

This seems to be one of the last remaining instabilities in our E2E tests at the moment.

Summary of all failing tests
FAIL specs/modules/tagmanager/setup.test.js (63.599s)
  ● Tag Manager module setup › Setup without AMP active › displays account creation form when user has no Tag Manager account

    TimeoutError: Navigation timeout of 30000 ms exceeded

      at ../../node_modules/puppeteer/src/common/LifecycleWatcher.ts:204:18

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

The specs/modules/tagmanager/setup.test.js E2E test should no longer fail from a navigation timeout error

Implementation Brief

On the following test cases, update the waitForNavigation calls to include an option of waitUntil with the value of networkidle2 and timeout with the value of 0.

Adding a little higher estimate here as this would include a lot of testing with the CI E2E tests and waiting for each to complete (this cannot be reproduced locally).

POC PR in a fork for exploration: https://github.com/nfmohit/site-kit-wp/pull/3

Test Coverage

No other tests need to be added/updated.

QA Brief

QA:Eng

Check the status of workflows labelled E2E Tests that have run after merging the PR of this issue.
Verify that any failing E2E test doesn’t have the navigation timeout error from specs/modules/tagmanager/setup.test.js.