Update and consolidate stories for existing tags

Feature Description

As part of the effort of simplifying cases around the handling of existing tags, we have a number of “duplicate” stories now due to the removal of “access” to a tag as a factor.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The following old stories under Analytics module / Setup and Analytics module / Settings below should be removed
  
• New stories for existing tags should be created accordingly using the newer CSF format, co-located with their respective components’ .stories.js
  • Modules/Analytics/Setup/SetupFormUA/:
    • ExistingTag – Existing UA tag, no property selected
  • Modules/Analytics/Setup/SetupFormGA4/:
    • ExistingTag – Existing GA4 tag, no property selected
  • Modules/Analytics/Setup/SetupFormGA4Transitional/:
    • ExistingTagUA – Existing UA tag, non-matching property selected
    • ExistingTagGA4 – Existing GA4 tag, non-matching property selected
    • ExistingTagUAGA4 – Existing tags, both UA+GA4 matching selected properties
    • ExistingGTMPropertyUANonMatching – GTM (UA) property that does not match the selected UA property ID
    • ExistingGTMPropertyUAMatching – GTM (UA) property that does match the selected UA property ID
  • Modules/Analytics/Settings/SettingsEdit/:
    • ExistingTagUA – Existing UA tag, non-matching property selected
    • ExistingTagGA4 – Existing GA4 tag, non-matching property selected
    • ExistingTagUAGA4 – Existing tags, both UA+GA4 matching selected properties
    • ExistingGTMPropertyUANonMatching – GTM (UA) property that does not match the selected UA property ID
    • ExistingGTMPropertyUAMatching – GTM (UA) property that does match the selected UA property ID

Implementation Brief

• In stories/module-analytics-setup.stories.js and stories/module-analytics-settings.stories.js, remove the stories mentioned in the AC.
• Using assets/js/modules/analytics/components/setup/SetupFormUA.stories.js,
  • add a new story as per the AC for SetupFormUA with the setup form in its initial state, i.e no property selected.
    • In order to do so, no account should be selected.
    • The call to set the account, registry.dispatch( MODULES_ANALYTICS ).selectAccount( accountID ); in the global story decorator might need to be moved to invidual stories where we need to set the account.
• Same points as the above but applied to SetupFormGA4.
• For SetupFormGA4Transitional and SettingsEdit, refer to the old stories in stories/module-analytics-setup.stories.js and stories/module-analytics-settings.stories.js for the actions to be dispatched in order to recreate the stories.
• Refer to the AC for the story names.

Test Coverage

• VRT might need to be updated in case they are relying on the old stories.

QA Brief

Note: Although the IB talks only about adding stories, there are a number of existing stories which cover some or all of the AC and needed to be modified rather than adding new ones. As such, the story names used have been kept consistent with existing stories.

Also, note that it’s not technically possible/realistic to implement the proposed ExistingTag – Existing GA4 tag, no property selected story so this has not been attempted.

• Check the stories listed to be removed in the AC have been removed.
  • Note that the stories Edit, with existing tag w/ access and Edit, with existing tag w/o access in Analytics Module/Settings were determined to be the equivalent of the listed Existing Tag w/ access and Existing tag w/o access stories and were deleted.
• Ensure the highlighted stories implement or are updated in line with the AC, notwithstanding the notes above.

Screenshots for reference:

Modules/Analytics/Settings/SettingsEdit

With UA Tag, non-matching property selected

With GA4 Tag, non-matching property selected

With Both Tags, both UA+GA4 matching selected properties

With GTM (UA) property that does not match the selected UA property ID

With GTM (UA) property that does match the selected UA property ID

Modules/Analytics/Settings/SetupFormGA4Transitional

With UA Tag, non-matching property selected

With GA4 Tag, non-matching property selected

With Both Tags, both UA+GA4 matching selected properties

With GTM (UA) property that does not match the selected UA property ID

With GTM (UA) property that does match the selected UA property ID

Modules/Analytics/Settings/SetupFormUA

With UA Tag, no property selected

Changelog entry

• N/A

[felixarntz]

@aaemnnosttv ACs lgtm, two points:

• For all the new stories around existing tags (not GTM tags), can you define whether the story should have the same property selected or another property selected? I agree we don’t need to have one story with both of these situations for each, since it can just be toggled within the story, but we should define what the initial state of the story should be.
• It might make sense to maybe put the removals first. Of course we need to read the whole ACs anyway, but it may sound a bit confusing to first have to update “all stories related to existing tags” but then later remove a bunch of them. So maybe put the removal first, and then say something like “all remaining stories related to existing tags”?

[aaemnnosttv]

I found an additional story in AC which screenshots and details are not mentioned in QAB. Is the story “With GA4 tag , non matching property selected” and story mentioned below are same ?

@mohitwp yes, they are the same 👍

I found few additional stories under Modules/Analytics/Settings/SettingsEdit/ . See highlighted stories under below screenshot. These stories are not on main branch and also not under QAB screenshot. Is this due to changes introduced in any other ticket ?

These were added as part of #5301