File.publicUrl() returns an incorrect URL if the file key contains URL query parameters

Environment details

• OS: Google Cloud Function (1st gen)
• Node.js version: 14.19.1
• npm version:
• @google-cloud/storage version: 5.8.5

Steps to reproduce

1. Upload a file to Cloud Storage containing query parameters in the key – example: somefile.jpg?state=thumbnail
2. Make the file public via File.makePublic()
3. Retrieve the file’s public URL with File.publicUrl()

The returned URL looks like https://storage.googleapis.com/bucket/somefile?state=thumbnail but any attempt to download the file at that URL results in the following error:

<Error>
  <Code>AccessDenied</Code>
  <Message>Access denied.</Message>
  <Details>Anonymous caller does not have storage.objects.get access to the Google Cloud Storage object.</Details>
</Error>

HOWEVER Viewing the file in the Google Cloud Platform Cloud Storage web console does give the correctly-encoded URL which looks like https://storage.googleapis.com/bucket/somefile.jpg%3Fstate%3Dthumbnail

I’ve reviewed the Changelog for subsequent releases but there is no mention of a fix for this.

[ddelgrosso1]

Hi @sseppola it was intentional from the standpoint that other spots in the code are currently encoding the entire name portion as I applied in the fix. Your suggestion makes sense to me, let me investigate if switching to something like this will have any other possible consequences.

[sseppola]

Makes sense, thanks for resolving it so quickly 👍