4.3.1 stop working on production

Hi, Since yesterday our projects that use Comlink stop working.

Downgrading the package solved the problem:

Is there anything in this 4.3.1 release that I should do for the workers?

Here’s a simple example that was not working:

importScripts("https://unpkg.com/comlink/dist/umd/comlink.js");

const ApiWorker = {
  fetch: async (url, options = {}) => {
    try {
      const res = await fetch(url, options)
      const json = await res.json()
      return [json, !res.ok]
    } catch (error) {
      console.warn('At api.worker.js -> ', error, url)
      return [error, true]
    }
  }
}

Comlink.expose(ApiWorker)

Debugging it looked like this promise never ended. No error, no feedback. Just didn’t end. I tried the same code without the worker and it worked perfectly.

Thanks,

Edit: Changing to 4.3.0 did also work

[iguto]

hi, @dy-byron I had similar problem. in my case, worker was running with comlink@4.3.1, but main was running with 4.3.0. After I update comlink version on main, worker works fine. So you might need to update version on main.

I hope this helps.

[maksnester]

I have a case when a worker wrapped with comlink lives in a separate npm package and uses comlink 4.3.0, and I have a library that uses that worker with comlink. The library had a range version ^4.3.0. So when a client app installs that library, it fetches comlink 4.3.1 and everything got broken 🙃

this to be a minor version bump

@surma but breaking changes are supposed to change major version… Though #475 looks innocent and doesn’t change API itself, it is still a literally breaking change as this issue shows.