Communication between 4.3.0 and 4.3.1 fails

I’m using comlink with iframes and I’m seeing communication between frames fails when the parent app is running v4.3.1 and the child app is running 4.3.0. Specifically the promise returned from this line never seems to resolve:

// child app
wrap(windowEndpoint(window.parent, window, targetOrigin)).callParentMethod();

This is a major issue for us because the two different frames are separate apps maintained by different teams and have different release schedules so it impractical for us to coordinate a comlink upgrade. For now we are pinning our versions to 4.3.0

[maksnester]

Unpublish 4.3.1?

Definitely not, some people already upgraded to it and it works fine. Unpublishing will break those apps/libs.

I can think of only 2 possible options here:

1. Do nothing. Make people sad but force them to update everything to the latest version.
2. Publish 4.3.2 with revert to make those apps affected by 4.3.1 work again (once updated). Go for 5.0 with breaking changes. Yeah, API remained the same, but does it matter if apps are broken after the update?

I’m personally OK with the 1st option here since I already spent some time updating things 😄

[guanzo]

If you change the protocol then it’s a breaking change, regardless if the public API is unchanged.

I remember when a minor version upgrade of Comlink broke my app (the shape of the error object was changed), so I pinned Comlink to its minor version. Now a patch version upgrade broke my app, so now I have to pin Comlink to a specific version.

I don’t think Comlink makes it clear enough that you must use compatible versions of Comlink in all of your frames. Compatible here meaning, basically the same exact version. With the way comlink is versioned - protocol changes introduced in minor/patch versions - it’s too easy to break production.