Android (scene) background color

Hi! As always, it’s so pleasant using your navigation library. This time a come w/ a couple of requests. This is for Android, next for iOS. I could manage to help w/ a PR if you let me know some guidelines in how to do it, eg how do you try things before release, because I’ve touching sources under node_modules and obviously it’s not the best approach!

Anyway, I have an app w/ dark background. I noticed on Android that there’s a flash-y feeling just before all the screen is rendered, caused because the default background color for everything in RN Android is white. I tried the underlayColor prop but no success. After debugging with Flipper layout inspector I saw that changing the opacity of SceneView to zero, the background color from the stack underlayColor is there. First I tried to add this to. SceneViewManager:

@ReactProp(name = "underlayColor", customType = "Color", defaultInt = Integer.MAX_VALUE)
public void setUnderlayColor(SceneView view, int underlayColor) {
    view.setBackgroundColor(underlayColor);
}

It doesn’t work yet because I guess I need to change things on js land… btw, I preferred ask here before to check out how do you see this…

Thanks!

[iamyellow]

btw, how cool is this… not only your lib is amazing, you’re so responsive, kind and always helping! we’re making and app that is going to be great, I can feel it! and people will know the nav library behind.

[iamyellow]

sounds crazy good!