Modal Popover not centered with UIBarButtonItem

This is related to https://github.com/grahammendick/navigation/pull/443.

Seems like there is an issue with centering the Action Sheet on iPad.

When the image prop is provided to the BarButton, it seems to be the most obvious offender. It is less noticeable when the title or systemItem is used.

A potential cause for could be found in the NVBarButton.m in:

- (void)layoutSubviews
{
    [super layoutSubviews];
    UIView *buttonView = ((UIView *) [self.button valueForKey:@"view"]);
    UIView *barView = buttonView.superview;
    UIView *labelView = buttonView.subviews.count > 0 ? buttonView.subviews[0] : buttonView;
    CGRect labelFrameInBar = [buttonView convertRect:labelView.frame toView:barView];
    self.frame = [barView convertRect:labelFrameInBar toView:nil];
}

According to this StackOverflow Post, the convertRect does not accurately get the frame of UIBarButtonItem when not created with init(customView: UIView) and/or when the UINavigationBar has not laid out all of its subviews.

[grahammendick]

Thanks @Dwar3xwar & @ndco. See the release notes for your credit

[Dwar3xwar]

Nice to see this get resolved!