Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

ts: Theme interface definition

See original GitHub issue
  1. Please extract the theme interface from

into an export interface ThemeType { … }

  1. Please use the theme type in <Grommet /> component:

  2. To avoid hack code issues, can you please take out the code from themes/index.d.ts and move it into base.d.ts etc and export them all from themes/index.d.ts so any future typescript conversion remains compatible with the .js code.

  3. Please use the theme interface type for exporting the themes ie themes/grommet.d.ts

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

spenc53commented, Oct 3, 2019

I’d like to take a look at this one if that is ok 😃

spenc53commented, Oct 9, 2019

It’s ready for review! Here is the PR! I tried my best to follow the contributing guide but, if I missed something, just let me know 😃

Here is a link to the PR

Read more comments on GitHub >

github_iconTop Results From Across the Web

The Theme type represents all possible themes. It might be what you need when you're writing a library of reusable components or an...
Read more >
Theme with styled-components and Typescript
Firstly, we will need to define how our theme interface looks like. Inside src folder, create styled.d.ts file and extend the existing ...
Read more >
Create styled.d.ts to make Typescript work with ...
TL;DR Create theme.ts I put mine in /theme/theme.ts. ... theme type definition from the above theme.ts file. export interface DefaultTheme ...
Read more >
Extend Material-UI theme in TypeScript
Material-UI is one of the most popular React component library in the world because it's easy to use and fast.
Read more >
How to extend Material UI 3 theme Typescript definition ...
But in the Material UI override.d.ts file, Overrides is not an interface but a type (so it won't be extensible this way), which...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found