Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
ts: Theme interface definition
See original GitHub issue- Please extract the theme interface from https://github.com/grommet/grommet/blob/c7eef0ff87f6579bd16c81e5b8c8c6ef17214e3c/src/js/themes/index.d.ts#L71
into an export interface ThemeType { … }
-
Please use the theme type in
<Grommet />component: https://github.com/grommet/grommet/blob/c7eef0ff87f6579bd16c81e5b8c8c6ef17214e3c/src/js/components/Grommet/index.d.ts#L7 -
To avoid hack code issues, can you please take out the code from
themes/index.d.tsand move it intobase.d.tsetc and export them all fromthemes/index.d.tsso any future typescript conversion remains compatible with the .js code. -
Please use the theme interface type for exporting the themes ie
themes/grommet.d.ts
Issue Analytics
- State:
- Created 4 years ago
- Comments:6 (6 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
I’d like to take a look at this one if that is ok 😃
It’s ready for review! Here is the PR! I tried my best to follow the contributing guide but, if I missed something, just let me know 😃
Here is a link to the PR https://github.com/grommet/grommet/pull/3448