Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Typescript definitions - extract types
See original GitHub issueThe types for common properties like align, gap, margin etc. need to be extracted in a core types file. The current typescript implementation leads to code duplications, both in grommet itself and in the applications using grommet.
https://github.com/grommet/grommet/blob/9a2663082bb21bb5d4a947cedfdc769451c72522/src/js/components/Box/index.d.ts#L7
for example
export type GapProp = "xxsmall" | "xsmall" | "small" | "medium" | "large" | "xlarge" | string;
export interface BoxProps { ... gap?: GapProp, ... }
Issue Analytics
- State:
- Created 4 years ago
- Reactions:4
- Comments:5 (3 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
Thank you @taysea & @britt6612 for working on this issue! I’m closing the issue but let’s keep our eyes open to keep optimizing the typescript coding.
I opened one more PR (see above), but after that I think we can close this.