G4 - Did you forget to signal async completion?

Hello, in the process of transitioning from G3 to G4 and I’ve ran into a snag with one of my tasks. I’ve tried a standard function and gulp.series() with no luck. Both tasks bark out:

The following tasks did not complete: svg-2-png
[09:17:32] Did you forget to signal async completion?

Tasks:

function svg2png(done){
    return gulp.src(appDefaults.imagesDir+"/*.svg")
        .pipe(svg2png())
        .pipe(gulp.dest(appDefaults.imagesDir+'/fallbacks'));
        done();
}

gulp.task('svg2png', gulp.series(function(done){
    gulp.src(appDefaults.imagesDir+"/*.svg")
        .pipe(svg2png())
        .pipe(gulp.dest(appDefaults.imagesDir+'/fallbacks'));
        done();
}));

gulp.task('svg-2-png',svg2png);

I think this is going to be something documentation could help for folks like me moving from 3 to 4. I read blog posts about this but don’t see any reference to done(); in readme 😉

[yocontra]

Just return the stream, you don’t need to call the callback at all.

function svg2png(){
    return gulp.src(appDefaults.imagesDir+"/*.svg")
        .pipe(svg2png())
        .pipe(gulp.dest(appDefaults.imagesDir+'/fallbacks'));
}

If you were doing something that didn’t have a stream, you can use the callback to signal done instead of returning a stream. You never do more than one.

[phated]

@jackesdavid that is not the appropriate fix. Even if you improperly use those methods inside functions, you need to pass the callbackA to the invocation.