v4 watch now runs one time and no more in some cases
See original GitHub issueCommit: https://github.com/gulpjs/gulp/commit/6c03475e1a39d18c139b4d56baa1c14a587f9f4a
I apologize in advance for this terrible issue report, I’ve been chasing this for hours and I’m afraid I have little to share, but I hope in the end someone can point me in the general direction of my error.
I had no problems until I pulled the latest, I generally stay up to date. Both gulp and gulp-cli are the lates.
I note from the ^^^commit a few others have seen the same change break their code. It is likely to be improper use, but I’m not spotting it in my code.
I created a test case and have been unable to reproduce: https://github.com/alienfast/gulp-pipeline/tree/master/test/watch-repeated
This test case works fine, both in the simple
form and with the gulp-pipeline recipe
form.
The case where it doesn’t work is in when using an Aggregate
, which does some task generation and surely this is the most likely place for my error.
What I can say, definitively, is that the file watcher is triggering and I receive those events, but inside glob-watcher
#runComplete
is never run again (after the first run).
Since #runComplete
is never run, what error would that indicate in my use? Missing passing through the done
?
Issue Analytics
- State:
- Created 7 years ago
- Comments:11 (6 by maintainers)
Top GitHub Comments
You should just be able to receive and call the
done
callback. All the examples haven’t been updated yet.Agreed. I tried but failed miserably. I just bumped into another case where I want to do something similar.
How could you run 3 watches from a single registered task and have it return properly? The readme has a sample but I see it doesn’t return either, does it?