Colliding async routes don't work as expected

👋 If you have two synchronous routes that overlap as I’d expect:

app.get('/a', c => c.text('a'));
app.get('/:slug', c.text('slug'));

Requesting /a returns a, and requesting /b returns slug.

However, if these routes are asynchronous, then things don’t behave correctly:

app.get('/a', async c => {
    await new Promise(resolve => setTimeout(resolve, 10));
    return c.text('a');
});
app.get('/:slug', async c => {
    await new Promise(resolve => setTimeout(resolve, 10));
    return c.text('slug');
});

Requesting either /a or /b results in slug being returned. Would be great to see this fixed so that there is a deterministic priority for route matching that is consistent.

[MattIPv4]

Just bumped and can confirm this is now behaving in a far more intuitive way to me (first handler that returns stops the chain)! Tyvm!

[yusukebe]

Hi @MattIPv4

Actually, the behavior in that both handlers are invoked is expected. So,

If I then look in console, I see both slug and a logged

That is not wrong. Because all handlers are treated as Middleware. Every handler are called, and only one of the Response returned from the handlers will be used for the end-user.

It’s in the specifications.

BUT, I notice that this design is not good. In this case, only one handler should be processed, console.log should emit only a.

I’ll consider it. Thank you!