Processed handler should be only one

In the Iusse #189 , we decided to treat handlers and middleware as the same. We can write like these:

app.post('/a', basicAuth(), bodyParse(), (c) => c.text('a)')

This is good.

How about Handler + Handler pattern.

app.get('/a', (c) => {
  console.log('a')
  return c.text('a')
})

app.get('/:slug', (c) => {
  console.log('slug')
  return c.text('slug')
})

This Response body will be a. This is expected.

BUT, in #258 I notice that every handler is processed. console.log emits slug, a.

The reason:

• All routes including middleware are treated as the same.
• A path will match multiple routes = handlers or middleware.
• If multiple handlers are matched, every handler will be invoked.
• Route returning Response object is determined as the handler.
• We don’t know whether the route is a handler or Middleware until dispatching 😕

I think this design is not so good. Only one handler should be invoked. In this case, console.log should emit only a. So, we have to:

• Determine handler or middleware.
• Make only one handler invoked.

How can we do that?

[dan-lee]

Hey @yusukebe, thanks a lot for your great work! It works perfectly now 🤩

[yusukebe]

Hi @dan-lee !

We’ve released v1.4.1. https://github.com/honojs/hono/releases/tag/v1.4.1

This release includes the feature that you expected. Update routing priority and fixed the issue about GraghQL server middleware. The following code works well. Please check it out!

import { buildSchema } from 'graphql'
import { Hono } from 'hono'
import { graphqlServer } from 'hono/graphql-server'

const app = new Hono()

const schema = buildSchema(`
type Query {
  hello: String
}
`)

const rootValue = {
  hello: () => 'Hello Hono!',
}

app.use(
  '/graphql',
  graphqlServer({
    schema,
    rootValue,
  })
)

app.get('*', (c) => {
  return c.text('fallback')
})

export default app