[BUG] logger.assign does not add properties to "request completed" log.

[x] I’ve read the docs of nestjs-pino

[x] I’ve read the docs of pino

[x] I couldn’t find the same open issue of nestjs-pino

What is the current behavior?

When I call this.logger.assign({ someKey: someValue }), the key is properly added to the logs that belong to a request except the one that marks the end of the request “Request completed”.

What is the expected behavior?

I would expect that the method this.logger.assign({ someKey: someValue }) adds the key and value to all the logs belonging to that request.

Please mention other relevant information such as Node.js version and Operating System.

I am using nestjs-pino 2.2.0.

[iamolegga]

Unfortunately, after spending a whole day on this I could not find a solution. I believe this feature should be made on pino-http first without adding any workarounds. Will add this limitation to docs

[iamolegga]

Just checked such example:

const express = require('express');
const pinoHttp = require('pino-http');

const app = express();

app.use(pinoHttp({ prettyPrint: true }));

app.get('/', (req, res) => {
  req.log = req.log.child({ foo: 'bar' });
  res.send('foo bar');
});

app.listen(8080);

and this doesn’t work.

All the suggested here dirty hacks cannot be used because it’s not universal for library with many users or add unnecessary complexity to configuration. Will check if we can solve this with AsyncLocalStorage, but in case if it’s not possible I’ll add this to the docs as a limitation of the underlying library.