[BUG] Missing stack trace of thrown error in log produced by nestjs built-in error handler

[x] I’ve read the docs of nestjs-pino

[x] I’ve read the docs of pino

[x] I couldn’t find the same open issue of nestjs-pino

There is an open issue https://github.com/iamolegga/nestjs-pino/issues/535, but that issue focuses on express, but I am not convinced my issue is related to express.

What is the current behavior? nestjs-pino@2.3.0 is missing stack traces

What is the expected behavior? Stack traces should be included in error logs, just like previously in nestjs-pino@1.4.0

Please provide minimal example repo. Without it this issue will be closed I created two NestJS applications, older one includes stack traces in error logs, newer version does not.

See examples here: https://github.com/raidokaldma/nestjs-pino-issue

[iamolegga]

shipped in v2.3.1

[iamolegga]

Finally found the bug. Working on fixing it.

In short, there is a difference between nestjs built-in LoggerService interface in v7 and v8. v7’s error method has stack argument, but in v8 it’s dropped for consistency between all the other methods. But in many places of the nestjs sources it’s still called like in v7, so this becomes a headache for lib owners to detect if optionalParams contains stack to properly set such field when logging error 😅

This issue differs from #535 because here the reason is a difference between logger versions and the logger call in exception handlers, and #535 is about request completed/errored pino-http’s log