Slate history refocusing causes "Incomplete set_selection operation properties" error

Do you want to request a feature or report a bug?

Bug

What’s the current behavior?

This following procedure causes the editor to throw Error: Cannot apply an incomplete "set_selection" operation properties {"focus":{"path":[0,0],"offset":6}} when there is no current selection.

1. Open up an official slateJS example
2. Select and delete two or more parts of the elements in the editor. Note that deleting part of one element or two of more full elements do not cause this error.
3. Click away to lose focus.
4. Click anywhere in the editor to gain focus.
5. Try to undo with HistoryEditor.undo (control/command + Z).

JSFiddle: here

Slate: 0.59.0 Slate React: 0.59.0 Slate History: 0.59.0 Browser: Chrome OS: Mac

What’s the expected behavior?

Undo should reverse the last action instead of throwing an error.

My Best Guess

I am new to SlateJS but my best guess of this error is that when the user clicks away and then into the editor, the selection does not get updated by Slate, which is why to Slate there is no current selection. After the user clicks into the editor to refocus, if the user updates the selection by typing something or deleting something else, then this error wouldn’t occur.

[TheSpyder]

Is this still a problem in the latest release? #3616 should fix it

[ulion]

My final plan for this is to not produce incomplete set_selection op: https://github.com/xliulian/slate/commit/956b8733ddc001c52a2b59c76c930ad75b4c7b8a