Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

'split_node' op: can't exclude node properties

See original GitHub issue

Do you want to request a feature or report a bug?

In Editor.transform a split_node operation always results in a spread of all object properties of the node that is being split into the newly inserted node. Because of that there is no way to exclude properties. The properties are already included in the properties property so there seems to be no need for this.

What’s the current behavior?

Node properties are always included into the newly inserted node for a split_node operation

What’s the expected behavior?

Only merge properties from the properties object into the new node for a split_node operation

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:6 (2 by maintainers)

github_iconTop GitHub Comments

TheSpydercommented, Jan 4, 2021

That’s the same case as uuid though. Instead of adding a property you’re changing one.

Fundamentally, hand crafting a split_node operation to avoid two separate API calls to split the node and then update the second block will break a core assumption about the contents of split_node operations. This might not impact cases where collaboration isn’t used, but it could cause weird behaviour with undo/redo. And you never know when you might decide to add collaboration later.

I don’t agree with the reasons this issue was created, but a side effect of my PR fixing the collaboration bug is that these scenarios will become feasible. I don’t think that should stop us merging my PR, Ian has approved it after all, it’s just worth noting.

BrentFaresecommented, Jan 31, 2021

Fixed by #4004.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Suspicious extra node with opset 13 #1543 - GitHub
The Split node to the left does not appear when using opset 9. I initially thought this node was unconnected but I believe...
Read more >
How to exclude sub-nodes in an AEM package using filters
Yeah, I misunderstood how AEM interprets the exclude filter on install. If the node is in the package zip but not in the...
Read more >
Filter Nodes Exclusions - Network Performance Monitor (NPM)
While using the Filter Nodes option in Custom View, how can I include certain results while excluding others in the same query.
Read more >
Reference manual - ProseMirror
innerDecorations holds the decorations for the node's content. You can safely ignore this if your view has no content or a contentDOM property, ......
Read more >
Application Monitoring - AppDynamics Documentation
See App Agent Node Properties Reference. Monitor Development Environments. On this page: Change the Monitoring Level. Effects of Using Development Mode.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found