Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
'split_node' op: can't exclude node properties
See original GitHub issueDo you want to request a feature or report a bug?
In Editor.transform a split_node operation always results in a spread of all object properties of the node that is being split into the newly inserted node. Because of that there is no way to exclude properties. The properties are already included in the properties property so there seems to be no need for this.
What’s the current behavior?
Node properties are always included into the newly inserted node for a split_node operation
What’s the expected behavior?
Only merge properties from the properties object into the new node for a split_node operation
Issue Analytics
- State:
- Created 3 years ago
- Comments:6 (2 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
That’s the same case as
uuidthough. Instead of adding a property you’re changing one.Fundamentally, hand crafting a
split_nodeoperation to avoid two separate API calls to split the node and then update the second block will break a core assumption about the contents ofsplit_nodeoperations. This might not impact cases where collaboration isn’t used, but it could cause weird behaviour with undo/redo. And you never know when you might decide to add collaboration later.I don’t agree with the reasons this issue was created, but a side effect of my PR fixing the collaboration bug is that these scenarios will become feasible. I don’t think that should stop us merging my PR, Ian has approved it after all, it’s just worth noting.
Fixed by #4004.