Review: DVC-tracked files intergration

Review placeholder for the https://github.com/iterative/vscode-dvc/issues/207 . I’ll keep updating it. Feel free to create specific tickets/PR to address items here (refer to comments).

• In the SCM tree we don’t want to show changes that correspond to the pipeline dependencies. Also, we can’t assign actions (push/pull) to them - https://github.com/iterative/vscode-dvc/issues/330#issuecomment-827317109
• Manage (e.g. pull) DVC-tracked directories from the SCM view as a whole https://github.com/iterative/vscode-dvc/issues/330#issuecomment-827318034
• Performance: dvc list keeps running itself ~https://github.com/iterative/vscode-dvc/issues/330#issuecomment-827326600~ https://github.com/iterative/vscode-dvc/issues/330#issuecomment-831648927
• Experiments commands in the SCM dropdown is not very relevant - https://github.com/iterative/vscode-dvc/issues/330#issuecomment-827340817
• Extending file watcher for updates to views - This comment
• Unrelated files in the SCM views (not tracked by DVC or Git) - https://github.com/iterative/vscode-dvc/issues/330#issuecomment-831649481
• Different icons for directories in the SCM tree https://github.com/iterative/vscode-dvc/issues/330#issuecomment-835912970
• Do not show DVC trees in non DVC repos https://github.com/iterative/vscode-dvc/issues/330#issuecomment-835913995
• Add push / pull to explorer tree https://github.com/iterative/vscode-dvc/issues/318#issuecomment-837607977
• Remove push / pull from inline SCM and add to repository level https://github.com/iterative/vscode-dvc/issues/318#issuecomment-837607977
• Change trees logic after the discussion in the https://github.com/iterative/vscode-dvc/issues/318 , example is here https://github.com/iterative/vscode-dvc/issues/330#issuecomment-842865096
• Adding data SCM tree view behavior is not clear - https://github.com/iterative/vscode-dvc/issues/330#issuecomment-843580760
• If we move to diff: Duplicate entries when file is tracked by git (incorrectly or not) - https://github.com/iterative/vscode-dvc/issues/330#issuecomment-844739515 (raise DVC issue?)
• Modified is not presented correctly? https://github.com/iterative/vscode-dvc/issues/330#issuecomment-848217287
• General performance- https://github.com/iterative/vscode-dvc/issues/330#issuecomment-827341763
• In the DVC Tracked Tree we should be showing progress for pull/push https://github.com/iterative/vscode-dvc/issues/330#issuecomment-843536818
• #609
• Failed fast instead of force flags https://github.com/iterative/vscode-dvc/issues/330#issuecomment-851734478
• Binary file open action error message behavior https://github.com/iterative/vscode-dvc/issues/330#issuecomment-851755392
• Do not grey out DVC-tracked files/directories. Use it for “still in cache”/missing? https://github.com/iterative/vscode-dvc/issues/330#issuecomment-851756898
• Deleting files in the dataset should make it modified - https://github.com/iterative/vscode-dvc/issues/330#issuecomment-851762235
• Glitch with tracking state on the file system - https://github.com/iterative/vscode-dvc/issues/330#issuecomment-851763528
• Implement regular file operations on trees. Probably worth creating a separate ticket - https://github.com/iterative/vscode-dvc/issues/330#issuecomment-857162792
• Decide on whether to extend force flag behaviour to push, pull, remove in the tracked explorer tree.
• Improve messaging for failed commands that may be fixed by use of force flags - https://github.com/iterative/vscode-dvc/pull/548#issuecomment-861038791

[skshetry]

It also appears that all progress output is suppressed when we call pull or push using the normal child process (different behaviour for non-TTY again?).

You can try setting DVC_IGNORE_ISATTY environment variable to force progress bars. But it might not be easy to parse tqdm’s progress bars. 🙂

[dberenbaum]

cc @skshetry