Show/Hide Columns TreeView
See original GitHub issueDepends on #358
I’m not sure if TreeViews have native checkmarks like the design implies, but I could be wrong.
Extra context:
As stated previously we are in the process of moving a lot of the functionality that currently resides in the experiments webview into the extension. We are doing this so that we can provide a more native UX/UI. We’ll be exposing the following functionality via the LHS side bar:
- Show / hide columns
- Filter rows based on values
We’ll be doing this by (mainly) utilising VS Code’s tree view and quick pick functionality.
#521 is in the process of being finalised. The purpose of that PR is to close #358. That means that we can shift the responsibility that we just removed from the webview (#546) to the extension.
The first step in our rough plan is to implement the above design (more in figma) in a tree view and then as a second step wire it up to the react table. In order to add the tree we’ll probably need to add a view container (see this section) to house the show / hide columns tree.
Notes:
- There is a lot of information here, please ask questions.
- The existing plan is rough / a guideline and should change as we get more information.
- We previously had a view container in the code base so feel free to checkout
extension/package.json
’s commit history. - The data structure shown in #521 is up for debate and can / should be changed to cater for the tree view (it has been built primarily to cater for React-table’s needs.
- There is a high probability that there will be some API limitations that will need to be worked around.
- We have an example of a tree view already in the code base (
extension/src/fileSystem/views/trackedExplorerTree.ts
).
Issue Analytics
- State:
- Created 2 years ago
- Comments:23 (10 by maintainers)
Top GitHub Comments
I hope to get started on this one over the weekend, but I’ve specifically set aside time on Monday and Tuesday (6/14-15) to focus on this 😊
Celebrated too soon. Still seeing the yaml error 😦
To remove the virtual environment, do I delete
demo/.env
?