new bug introduced/functionality removed in upgrade from 1.3 to 1.4

I just upgraded from mockito-1.3.0 to mockito-1.4.0 and many of my tests began to fail. Here is “somewhat minimal” example of what kind of code used to work, but it doesn’t anymore (python 3.7.3):

from typing import Callable
from nose.tools import assert_equal
from mockito import mock, when


class _c(object):
    def __init__(self, fn: Callable[[int], str]) -> None:
        self._fn = fn

    def get_val(self, a: int) -> str:
        return self._fn(a)


def test_foo():
    x = mock()
    c = _c(x.get_value)
    when(x).get_value(10).thenReturn('foo')
    assert_equal(c.get_val(10), 'foo')

result:

$ nosetests a.py 
F
======================================================================
FAIL: a.test_foo
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/spurny/py-venv/wf3/lib/python3.7/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/home/spurny/src-experiments/mockito-1.4-bug/a.py", line 18, in test_foo
    assert_equal(c.get_val(10), 'foo')
AssertionError: None != 'foo'
----------------------------------------------------------------------
Ran 1 test in 0.000s
FAILED (failures=1)

but if I mock the x.get_value before creating c:

...
def test_foo():
    x = mock()
    when(x).get_value(10).thenReturn('foo')  # moved here from below `c = _c(...` line
    c = _c(x.get_value)
    assert_equal(c.get_val(10), 'foo')

then it works fine:

$ nosetests a.py 
.
----------------------------------------------------------------------
Ran 1 test in 0.000s
OK

[kaste]

You mean a different way from your original example? Typically just pass in a mock(). Then early or late configuration works:

class _c(object):
    def __init__(self, fn):
        self._fn = fn

    def get_val(self, a):
        return self._fn(a)


def test_foo():
    x = mock()
    c = _c(x)
    when(x).__call__(10).thenReturn('foo')
    assert c.get_val(10) == 'foo'

In that case you can also turn on “strictness” so it has a better error message.

(Otherwise you always have the None is not ‘foo’ assertion error.)

[jan-spurny]

Perfect, thanks! I didn’t thought of mocking __call__…