Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Tidy e2e test Python environment

See original GitHub issue

There’s various things that are pip-installed in Ideally we shouldn’t be putting custom requirements in here. I tried removing them in #804 but it started failing some tests - looks like we need the click specification for testing on older version of kedro 0.16.

Given that the kedro requirements are going to continually keep bumping the version of click we should work out some better way of installing requirements here so that the testing environment is a clean as possible. Or maybe we should just forget about tests for 0.16 altogether?

There’s probably some other bits of tidying that would be useful here, e.g. setting PIP_DISABLE_PIP_VERSION_CHECK would be much nicer if done in the CI config, as we do on kedro.

Issue Analytics

  • State:open
  • Created a year ago
  • Comments:8 (8 by maintainers)

github_iconTop GitHub Comments

AntonyMilneQBcommented, Jul 18, 2022

@tynandebold I’ve re-opened this because I think the Python e2e tests still need work, even if we drop support for 0.16 - hope that’s ok.

studioswongcommented, Apr 14, 2022

@AntonyMilneQB thanks for the detailed outline of this situation! I 100% agree on the point that the “officially supported kedro versions” be the same as “kedro versions we test for”.

That said, @idanov made a fair point in standup yesterday that we are supporting 2 versions of Kedro, which, given the upgrade to 0.18, it does make sense to drop support for 0.16. Also noted on the fact that Kedro 0.16 causes tests to fail on Python 3.7 and it makes sense to drop the support altogether.

Great that you brought up about this comment on the contributing guide - it’s been a while since this issue was discussed ( 14 months ago - time flies!), the main context behind this lies from a user report that mentioned Kedro-Viz not working well with older versions of Kedro ( i.e Kedro <=0.16.6), where back then we did a bunch of tests within the team ourselves to test with different Kedro 0.16 versions and concluded that Kedro-Viz will work with 0.16.6 onwards. ( you can refer to this PR here for some context, while a lot of the discussion also happened on slack).

You’re right in that it’s not a set in stone statement, it was just a result from testing where we can safely advise users that Kedro-Viz >=3.8 will work with Kedro>=0.16.6 at that time and we made the releavant announcement about this on the kedro-user channel. If we are dropping support for Kedro 0.16 altoegther, it would be good to remind our users that as well so we can prompt them to upgrade to get the latest Viz goodies ( we should definitely keep in mind to include the statement that we are dropping support for Kedro <0.17.0 in our next release announcement)

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to create dynamic E2E testing environments | by Shai Tubul
There are several ways to implement E2E testing environments (like in all software ... Configuring and deploying an environment; Running automatic E2E tests...
Read more >
Set Up End-to-end Testing with Python and Playwright
Understand and analyze the application requirements and document user flows. Set up the E2E testing tool. Develop the test cases. Run the E2E ......
Read more >
An Introduction to Setting Up a Clean Testing Environment
Learn how to set up a clean testing evironment, core concepts for independent tests and more with Tom Shlaim at ironSource.
Read more >
Best Practices for Creating End-to-End Tests - Datadog
Configure tests by environment​​ For example, tests in a development environment may only need to run on one device, while tests in staging ......
Read more >
Catcher e2e tests tool for beginners | by Valery Tikhonov
your custom steps, written in Python, Java, sh or any other language you prefer. Simple example of how test can look like: steps:...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found