pyxel.cls(0) is not clearing the screen properly for some resolutions

Some pixels do not get overwriten(/overdrawn) on some resolutions.

import pyxel

class MyGame:
    def __init__(self):
        pyxel.init(100,100)
        self.x = 0
        pyxel.run(self.update, self.draw)

    def update(self):
        self.x = (self.x + 1) % pyxel.width

    def draw(self):
        pyxel.cls(0)
        pyxel.rect(self.x,0,self.x+7,7,9)

MyGame()

this code leads to this result:

but if I change the pyxel.init() to

pyxel.init(100,101)

the result is fine:

This code shows how the bottom and right border aren’t drawn properly

import pyxel

class MyGame:
    def __init__(self):
        pyxel.init(100,100)
        self.x = 0
        pyxel.run(self.update, self.draw)

    def update(self):
        self.x = (self.x + 1) % pyxel.width

    def draw(self):
        pyxel.cls(13)
        pyxel.rect(self.x,0,self.x+7,7,9)

MyGame()

• Win10,
• Python 3.6.2
• pyxel 0.7.4

[kitao]

Now I understood the cause. It’s the limitation of the point sprite size of OpenGL. It’s limited to 256 and Pyxel uses OpenGL point sprite to draw elements. So any element its size if over 256 is limited to 256. And cls is the same implementation as rect. So this problem happens.

It isn’t easy to remove this limitation on the current implementation. So please let this limitation as a specification of Pyxel for a while.

[kitao]

Hi, On SDL2 version of Pyxel, clipping is processed with pure software (not using OpenGL feature). So I don’t think this issue happen again on the latest version.

2019年7月2日(火) 12:06 Derek McCammond [e-mail]:

Hey @kitao https://github.com/kitao, now that Pyxel has moved to SDL2, does that mean that this could potentially get reopened? The reason I ask is because I’m trying to write some stuff specifically for the GPi case and that thing is 320x240. I can live with 256x240, but it doesn’t hurt to ask!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kitao/pyxel/issues/26?email_source=notifications&email_token=AAFFXEU4V6LQXVV77C2EP2LP5LA4HA5CNFSM4FNZYAIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY75KOY#issuecomment-507499835, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFFXEV7HTC6Y4RDJMU64TTP5LA4HANCNFSM4FNZYAIA .