import statement in readme seems to be wrong

The docs have this snippet:

// import update from 'react-addons-update';
import update from 'immutability-helper';

But the export looks like this:

module.exports = newContext();

Which works when you follow the docs on react-addons-update (seeing as it’s a drop-in replacement) for the import:

// var update = require('react-addons-update');
var update = require('immutability-helper');

But it doesn’t work when you use a bundler to transpile from ES6, because the docs’ ES6-style default import is misleading (this particular one is from my Webpack project):

Uncaught TypeError: immutability_helper_1.default is not a function

So should the interface be changed or the docs updated? I’m guessing the latter.

[seansfkelley]

@waldojeffers for libraries like this, you can always import * as update from 'immutability-helper', though depending on how exactly they are typed it may not actually work. I wrote the things for this library on DT, so I can assure you it works. 😃

@kolodny it’s still correct in javascript to import without default. It’s probably still worth changing the docs or adding that export statement you mention.

[seansfkelley]

Ah, looks like Babel tries to be clever and will see if it’s compiled by other Babel by looking for __esModule. I’m actually consuming this from Typescript, which doesn’t try to be clever (ignore the usage of define over require, it’s just doing that cause its in the browser).

Strictly speaking, the way it’s defined (namely, module.exports = ...) it should not be importable using default-import syntax, but Babel is trying to be helpful. Typescript explicitly doesn’t do this and Babel 6 stopped being clever about not emitting .default in some scenarios, so I think it’s probably not behavior that should be depended upon.