Toggle fullscreen when pressing `f`

The Issue

Pressing f while watching a video doesn’t toggle fullscreen.

Steps to Reproduce

1. Launch a video.
2. Press f.
3. Press f again, nothing happened.

Expected Behaviour

Fullscreen should be toggled.

Actual Behaviour

Nothing happens instead.

Suggested Solutions

Implement toggling fullscreen when pressing f.

System Configuration

• LBRY Daemon version: 0.30.1
• LBRY App version: 0.26.1
• LBRY Installation ID: 9ZfMD7MUia6AAvrTDx1MzxGpsEBxUcK3mSxou2VgCFrLSYWwyNavkCTrPBpo5GoTbK
• Operating system: Linux (Linux-4.18.0-13-lowlatency-x86_64-with-debian-buster-sid)

Anything Else

Screenshots

Internal Use

Acceptance Criteria

1. If not in fullscreen should go into fullscreen when pressing f.
2. If already in fullscreen, should go into window screen when pressing f.

Definition of Done

• Tested against acceptance criteria
• Tested against the assumptions of the user story
• The project builds without errors
• Unit tests are written and passing
• Tests on devices/browsers listed in the issue have passed
• QA performed & issues resolved
• Refactoring completed
• Any configuration or build changes documented
• Documentation updated
• Peer Code Review performed

[ngeiswei]

I could take a shot, though it might take me a while given how busy I am.

Question: would it be OK if it is hardwired?

Appreciation is always welcome 😃

[neb-b]

@ngeiswei No problem.

I just meant that we need to remove the event listener when the react component leaves the page. We don’t care if a user pressed f on the settings page. We do something similar here: https://github.com/lbryio/lbry-desktop/blob/master/src/renderer/component/wunderbar/view.jsx#L39-L41