Blank error associated with initial sd blob failure when downloading

The Issue

This issue was first reported by @nikooo in #mods chat and then it happened to me on my main PC. You get a blank pop

Looks like it happens when the daemon fails to download the sd blob with the first attempt (which happens as soon as you enter the claim). As soon as you click download, that’s when you get the blank warning pop-up. The get json returns fine when download is clicked. So to me, it seems like the error is being suppressed until it’s downloaded/streamed. The download does start and complete.

Think it may be related to this, but not sure: https://github.com/lbryio/lbry/issues/883

In my case this happened on lbry://ld-ESe4TsYVE0g#1595d087527198a00624dd5d3f13c2116a28a532 and lbry://ld-HDgKlqRA4hw#3bdc2fa1c8a679506a239b507ebb02ba350a474c

Steps to reproduce

1. Try downloading a couple videos from homepage
2. Watch daemon log to see if the content initially fails on the sd
3. Then click stream/download
4. Get warning popup

Expected behaviour

Either the sd blob shouldn’t fail or it shouldn’t throw an error if the download does start

Actual behaviour

Get an error even when download starts

System Configuration

• LBRY Daemon version: 0.15.1
• LBRY App version: 0.15rc2
• LBRY Installation ID:
• Operating system: Windows

Anything Else

2017-08-30 21:12:09,553 INFO     lbrynet.daemon.Daemon:2635: Need sd blob
2017-08-30 21:12:09,553 INFO     lbrynet.core.client.ConnectionManager:38: Connection Manager 4c9ce770083543c81312803403814a5cad7d885a41080917ca951a1ec4770e599df3de04c92b401fd6ece34d0f78290c initialized
2017-08-30 21:12:11,555 WARNING  lbrynet.daemon.Daemon:2644: Failed to download 4c9ce770083543c81312803403814a5cad7d885a41080917ca951a1ec4770e599df3de04c92b401fd6ece34d0f78290c within timeout
2017-08-30 21:12:14,365 INFO     lbrynet.core.server.BlobRequestHandler:151: Sending 211a97a9a23a0d05 to 27.72.41.136:49402
2017-08-30 21:12:19,680 INFO     lbrynet.daemon.Downloader:91: Download lbry://ld-ESe4TsYVE0g status changed to initializing
2017-08-30 21:12:19,683 INFO     lbrynet.daemon.Downloader:91: Download lbry://ld-ESe4TsYVE0g status changed to downloading_metadata
2017-08-30 21:12:19,683 INFO     lbrynet.core.client.ConnectionManager:38: Connection Manager 4c9ce770083543c81312803403814a5cad7d885a41080917ca951a1ec4770e599df3de04c92b401fd6ece34d0f78290c initialized
2017-08-30 21:12:20,601 INFO     lbrynet.core.client.BlobRequester:395: Offered rate 0.000000/mb accepted by 88.223.55.113
2017-08-30 21:12:20,740 INFO     lbrynet.core.client.BlobRequester:545: Blob 4c9ce770083543c8 has been successfully downloaded from 88.223.55.113:3333
2017-08-30 21:12:20,742 INFO     lbrynet.core.client.ClientProtocol:144: Closing the connection to 88.223.55.113:3333 due to having no further requests to send
2017-08-30 21:12:21,759 INFO     lbrynet.lbry_file.EncryptedFileMetadataManager:246: Saved sd blob hash 4c9ce770083543c81312803403814a5cad7d885a41080917ca951a1ec4770e599df3de04c92b401fd6ece34d0f78290c to stream hash 05fb31c9bb9ebe05fa5261c2c2b06998b500e939aee90eff24c6e0e6a123f398594e51ff9584d2dd4a741d3273b44b86
2017-08-30 21:12:21,782 INFO     lbrynet.daemon.Downloader:180: Downloading lbry://ld-ESe4TsYVE0g (4c9ce7) --> D:\LBRY Downloads Main PC\ESe4TsYVE0g.mp4

Screenshots

[nikooo777]

Yes, what i experienced was I clicked on a video I had never watched, the player loaded for around 30 seconds but in the network there were no calls being made.

After about 30 seconds, the error popup came up and at the same time the app started flooding the daemon with full_status requests without delays.

The video started playing behind the error popup, the error popup was empty as shown in the screenshot above.

I suggested that the portion of code responsible for this behavior is located here: https://github.com/lbryio/lbry-app/commit/d591886df55c47893c264f30d0ff932e157678fa#diff-313e02014d06fe554d4dd5ea2c2e7139R286

[tzarebczan]

Closing this in favor of #883