MapToListTypeAdapter nullability

(Using the default MapToListTypeAdapter)

Output types

If I have an object annotated like:

@GraphQLNonNull
@GraphQLQuery(name = "field")
public Map<@GraphQLNonNull String, @GraphQLNonNull String>getField() {
  return null;
}

In the schema I get the field field [mapEntry_String_String]!

The type mapEntry_String_String picks the non-nulls up fine for its fields, but I would expect the field to be of type field [mapEntry_String_String!]! as it doesn’t make sense to have a null map entry in the list.

Input types

If I have a field annotated like:

@GraphQLNonNull
@GraphQLInputField(name = "field")
private Map<@GraphQLNonNull String, @GraphQLNonNull String> field;

Then in the schema I get the field field [mapEntry_String_String_input!] I would expect it to be field [mapEntry_String_String_input!]! as it’s annotated to be non-null. The object mapEntry_String_String_input picks up the annotations fine for its own fields. Is there something I’m missing a way to mark these non-null myself? Seems like a bug to me.

summary

• For output types it applies the @GraphQLNonNull annotation correctly, but should change to make the generated mapEntry object always non-null.
• For input types is applies the @GraphQLNonNull annotation to the generated mapEntry object instead of to the list itself, and should have the mapEntry object be always non-null.

[kaqqao]

Ah, this is an exceptional case indeed, because it is Jackson that looks at private fields and not SPQR, but Jackson is configured to respect @GraphQLInputField annotations, so it seems surprising.

I opened a separate issue #160 about annotation on private fields, so track that one for progress.

[kaqqao]

I made the entries non-nullable, so that change will land in 0.9.8. The transparent treatment of private fields is in popular demand, so I’m starting the work on it. But I don’t want to delay the 0.9.8 release any further, so this will land in 0.9.9.

In the meantime, I’ll try replicating your setup, but if you have the time a simple test demonstrating the behavior you’re seeing would be helpful.

Cheers!