Pass instance as first argument to callbacks

I generally don’t like dealing with this. Mainly because of its interaction with arrow/non-arrow functions and secondly because tooling like linters can not statically determine which functions are bound and which are not, so they can not warn on a unused this.

Would it make sense to instead pass the current instance as the first argument to all callbacks? E.g. (uPlot, left, right, idx) for cursormove for example.

[leeoniya]

this is now done with the exception of .tzDate - i’ll probably leave it as-is, since it’s sufficiently different from other function-taking opts and hooks.

what ultimately convinced me was building out https://leeoniya.github.io/uPlot/demos/pad-scale.html

[leeoniya]

@alextarrell

Could it be the last parameter instead?

this requires a high degree of confidence that function signatures are perfect and makes it impossible to non-awkwardly add more params to the existing methods without breaking changes.

I feel that’s somewhat more commonplace in JS-land

i don’t feel this way at all. do you have some examples of popular libs that do this?

and would also not be a breaking change.

before v1.0, every commit can be breaking; i don’t make the rules, but someone smart did 🤣