Code is moved out of default case of switch

CFR version

0.150-SNAPSHOT (commit cf242d2)

Compiler

• javac 11.0.5
• javac 14

Description

Relates to #128

Code in the default case of a switch statement or expression with no other cases (or fall-through to default) is moved outside the switch. This is sometimes not possible, e.g. when the default case defines a local class with the same name.

Source:

class SwitchExpressionLocalClass {
    void test() {
        switch(0) {
            default: {
                class Test {
                    Test(int i) { }
                }
                
                new Test(1);
            }
        };
        class Test { }
        new Test();
    }
}

Decompiled output:

class SwitchExpressionLocalClass {
    SwitchExpressionLocalClass() {
    }

    /*
     * Inner class renamed, behaviour may change
     * Enabled force condition propagation
     * Lifted jumps to return sites
     */
    void test() {
        switch (0) {
            default: 
        }
        class Test_1 {
            Test_1(int n) {
            }
        }
        new Test_1(1);
        class Test {
            Test() {
            }
        }
        new Test();
    }
}

[Marcono1234]

Yeah, I briefly looked at the byte code and noticed that it does not provide the necessary information to easily tell where the local class is declared. So I am perfectly fine with you considering this a “never fix” (and closing this issue).

Thanks for letting me know that the process will be reduced. Apparently you have had a pretty long commute based on the amount of work you have put into this 😄 Stay well 😃

[leibnitz27]

As discussed - this isn’t going to be fixed, apart from the cases (like #128) where it’s possible to know which form must be required. (and the fix for #128 is fairly heavy handed, so I’m keen not to use it generally 😉 )