Statements placed before this() or super() call when using switch expression as argument

CFR version

0.150-SNAPSHOT (commit cf242d2)

Compiler

javac 14

Description

When using a switch expression (Java 14 feature) as argument for the call of this() or super(), statements are placed before the constructor call when decompiled which makes the code invalid.

Source:

class SwitchConstructorTest {
    SwitchConstructorTest(int i) { }
    
    SwitchConstructorTest(String s) {
        // Also happens for super();
        this(switch (s) {
           case "a" -> 1;
           default -> 2;
        });
    }
    
    SwitchConstructorTest(Byte b) {
        this(switch(b) {
           default -> 1; 
        });
    }
}

Decompiled output:

class SwitchConstructorTest {
    SwitchConstructorTest(int n) {
    }

    SwitchConstructorTest(String string) {
        // Invalid, no other statement must appear before call to this()
        int n = switch (string) {
            case "a" -> 1;
            default -> 2;
        };
        this(n);
    }

    SwitchConstructorTest(Byte by) {
        // Invalid, no other statement must appear before call to this()
        switch (by) {
            default: 
        }
        this(1);
    }
}

[leibnitz27]

This was, frankly, horrible.

Tests https://github.com/leibnitz27/cfr_tests/commit/4754c97dc412cf035aebf73ea484bd0c94e44648

[Marcono1234]

This was fixed for the first example where there is no fall-through to the default case by the fix for #129. However, the second example (fall-through to default case) still occurs, see also #133.