Clicking noise in production build of 1.0.0
See original GitHub issueSo when I build production on 0.9.0
, 0.10.0
, everything is fine. But when I build production on 1.0.0
, the sound has this weird clicking noise. I’m on React ^15.4.1
.
webpack.prod.js
const path = require('path');
const ExtractTextPlugin = require('extract-text-webpack-plugin');
const InlineEnviromentVariablesPlugin = require('inline-environment-variables-webpack-plugin');
const Dotenv = require('dotenv-webpack');
const nodeExternals = require('webpack-node-externals');
const {
commonRules: commonRulesBase,
resolveModules,
publicPath,
postcssConfig
} = require('./common.config');
const dotenv = require('dotenv');
dotenv.config();
const assetsPath = path.join(__dirname, '..', 'dist', 'public', 'assets');
const commonRules = [
...commonRulesBase,
{
test: /\.css$/,
use: ExtractTextPlugin.extract({
fallback: 'style-loader',
use: [
{
loader: 'css-loader',
options: {
modules: true,
localIdentName: '[path][name]__[local]___[hash:base64:5]'
}
},
{
loader: 'postcss-loader',
options: { plugins: postcssConfig }
}
]
}),
include: [path.join(__dirname, '..', 'app')],
exclude: [path.join(__dirname, '..', 'node_modules')]
},
{
test: /\.css$/,
use: ExtractTextPlugin.extract({
fallback: 'style-loader',
use: ['css-loader']
}),
include: [path.join(__dirname, '..', 'node_modules')],
exclude: [path.join(__dirname, '..', 'app')]
}
];
module.exports = [
{
name: 'client',
devtool: 'source-map',
context: path.join(__dirname, '..', 'app'),
entry: ['babel-polyfill', './client'],
output: {
path: assetsPath,
filename: 'bundle.js',
publicPath
},
module: {
loaders: commonRules
},
plugins: [
new ExtractTextPlugin({
filename: 'styles/main.css',
allChunks: true
}),
new InlineEnviromentVariablesPlugin(['NODE_ENV']),
new Dotenv()
],
resolve: {
modules: resolveModules
}
},
{
name: 'SSR',
context: path.join(__dirname, '..', 'app'),
entry: './SSR',
target: 'node',
output: {
path: assetsPath,
filename: 'SSR.js',
publicPath,
libraryTarget: 'commonjs2'
},
module: {
loaders: commonRules
},
externals: nodeExternals({
whitelist: [/\.(?!(?:jsx?|json)$).{1,5}$/i]
}),
plugins: [
new ExtractTextPlugin({
filename: 'styles/main.css',
allChunks: true
}),
],
resolve: {
modules: resolveModules
}
}
];
Issue Analytics
- State:
- Created 6 years ago
- Comments:9 (4 by maintainers)
Top Results From Across the Web
Causes of "clicking" sound *besides* short attack time?
I think Urs has the correct explanation for the clicking noise in this case, because Phantom, being an FM synth, uses only sine...
Read more >About clicking noise - FMOD Forums
I don't know what the correct term is but anyway clicking noise, tick noise or something keeps annoying me.
Read more >Playback "clicking" noise - c++ - Stack Overflow
It runs correctly except that at the end of the playback for any .wav file, there is a very noticeable "clicking" noise.
Read more >Powershot SX230 Clicking Noise - Canon Community
My Canon Powershot SX230 makes a continuous clicking noise, assuming its the continuous focus, but not sure. You can also hear it when...
Read more >Semantic Versioning 2.0.0 | Semantic Versioning
How do I know when to release 1.0.0? If your software is being used in production, it should probably already be 1.0.0. If...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Yeah it seems to be fixed now. Thanks for the help.
Fixed and published in https://github.com/leoasis/react-sound/releases/tag/v1.1.0, let me know if this is all ok now! Thanks for filing the issue and the example!