ArmeriaReactiveWebServerFactory's lamda in access log

2020-10-10 13:24:02.517  INFO 71589 --- [-worker-nio-2-1] com.linecorp.armeria.logging.access      : 0:0:0:0:0:0:0:1 - - 10/Oct/2020:13:23:07 +0900 "GET /#ArmeriaReactiveWebServerFactory$$Lambda$742/0x00000008005adc40 h1c" 200 22 "-" "curl/7.64.1" "-"

2020-10-10 13:24:02.517  INFO 87808 --- [orker-epoll-2-1] com.linecorp.armeria.logging.access      : 0:0:0:0:0:0:0:1 - - 10/Oct/2020:04:42:12 +0000 "GET /actuator/prometheus#ArmeriaReactiveWebServerFactory$$Lambda$659/0x0000000840524440 h1c" 200 1462778 "-" "Prometheus/2.19.0" "-"

When you run a Spring Webflux application with armeria-spring-boot2-webflux-starter, you can see those requests which are caught by this catch-all service are logged like the above, which are not that pretty.

I think that ArmeriaReactiveWebServerFactory’s lamda in access log is annoying and unnecessary information for access log, it seems better to remove it.

[delegacy]

FYI)

From armeria-examples/spring-boot-tomcat

2020-10-12 19:39:40.828  INFO 10853 --- [-worker-nio-2-2] com.linecorp.armeria.logging.access      : 0:0:0:0:0:0:0:1 - - 12/Oct/2020:19:39:40 +0900 "GET /#UnmanagedTomcatService h1c" 200 5 "-" "curl/7.64.1" "-"

From armeria-examples/spring-boot-minimal

2020-10-12 19:43:15.020  INFO 11137 --- [-worker-nio-2-1] com.linecorp.armeria.logging.access      : 0:0:0:0:0:0:0:1 - - 12/Oct/2020:19:43:14 +0900 "GET /#HelloAnnotatedService$$EnhancerBySpringCGLIB$$fa5f47f6/defaultHello h1c" 200 57 "-" "curl/7.64.1" "-"
2020-10-12 19:48:26.399  INFO 11137 --- [-worker-nio-2-3] com.linecorp.armeria.logging.access      : 0:0:0:0:0:0:0:1 - - 12/Oct/2020:19:48:26 +0900 "GET /not-found#FallbackService h1c" 404 13 "-" "curl/7.64.1" "-"

It seems logging service names in access log even for non-RPC requests is a default behavior in any case. Then, it could be better not to have lamda names/enhanced class names as service names.

Plus, we could think an option to omit service names in access log as well.

[ikhoon]

Plus, we could think an option to omit service names in access log as well.

If users want to format the access log dynamically, do we add an AccessLogWriterBuilder and build a format programmatically? For example:

AccesssLogWriter.builder()
                .add(AccessLogType.LOCAL_IP_ADDRESS)
                // Add a pattern if a condition is matched
                .add(AccessLogType.AUTHENTICATED_USER, log -> log.context().path().equals("admin"))
                // Modify a pattern and add it if a condition is matched
                .add(AccessLogType.REQUEST_LINE, log -> true, requestLine -> requestLine.replace(...))
                .build();