Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Feature Request] Support `MeterRegistry` Bean for Client in Spring integration

See original GitHub issue

Currently, the static global MeterRegistry is used for client metrics as per https://github.com/line/armeria/blob/3d30b065ee1a1542f54ffe3a03dea6b4cc36c959/core/src/main/java/com/linecorp/armeria/client/ClientFactoryOptions.java#L179

/**
 * The {@link MeterRegistry} which collects various stats.
 */
public static final ClientFactoryOption<MeterRegistry> METER_REGISTRY =
    ClientFactoryOption.define("METER_REGISTRY", Metrics.globalRegistry);

It would be nice if this has the ability to use a MeterRegistry bean like that of the server version

Issue Analytics

State:
Created 3 years ago
Comments:11 (6 by maintainers)

Top GitHub Comments

2reactions

trustincommented, Oct 14, 2020

In addition, what do you think of creating an auto-configuration class for Armeria client and making WebClientBuilder with bean?

You mean exposing WebClient without a base URL as a bean? That sounds fine to me.

0reactions

ikhooncommented, Jan 11, 2021

Sure, it is all yours. 😃

Top Results From Across the Web

Spring Integration Reference Guide

Integration Graph Controller; 28.9. HTTP Samples. 28.9.1. Multipart HTTP Request — RestTemplate (Client) and Http Inbound Gateway (Server). 29. JDBC Support.

Defining custom metrics in a Spring Boot application using ...

Once Prometheus collects these metrics, you can see the aggregate number of requests but also, you can drill down and examine the number...

3 Metrics Endpoint - Micronaut Micrometer

To execute the endpoint, send a GET request to /metrics . This returns the metric names registered with the MeterRegistry bean. You can...

Micrometer Metrics - Quarkus

Outbound HTTP request metrics support. Support for HTTP client metrics will be enabled if Micrometer support is enabled, the REST client feature is...

Spring Boot app metrics - with Prometheus and Micrometer

The good news is you can add Prometheus support to a Spring Boot application very easily. In fact there a couple of ways....