Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

filter-ed promises not being executed in componentDidMount

See original GitHub issue

BEGIN_GLOBAL_LOAD/END_GLOBAL_LOAD are dispatched on the client side even when filter stops the asyncConnect from blocking the render function. However, once the component is mounted, since the redux has saved the state loaded as true, it does not fetch the data. Due to this you have to manually redo the logic for re-fetching data in these instances. It would be nice to have some logic to ascertain that the promise is executed in componentDidMount.

Issue Analytics

State:
Created 7 years ago
Comments:6 (3 by maintainers)

Top GitHub Comments

4reactions

idangozlancommented, Dec 20, 2016

is there any solution / workaround for now?

1reaction

bobbypriambodocommented, Dec 7, 2016

I’ve just encountered this today, having just migrated from the unmaintained redux-async-connect@1.0.0-rc4. As such, I reverted back. It kinda sucks, I really wanted to leave redux-async-connect, since it complains that the react peerDependency version does not match, I’m using the latest 15.4.1.

Are the solutions provided not good enough?

Ideally I wanted to change the line where it checks for the “load” prop in componentDidMount, but not on the root of the reducer state, but for each prop with “key”, but because of that we’ll have to make sure that “key” is required for filtering

^ Is this a feasible solution?