JwksValidationHandler + requestAccessToken: false = Error validating tokens

Hi,

In my use case, we don’t use the access_token, we only use the id_token. So I’ve set requestAccessToken to false, but I still need to validate the id_token.

I’m validating the token using this.oauthService.tokenValidationHandler = new JwksValidationHandler();, which throw an error after the login:

angular-oauth2-oidc.js:1183 Error validating tokens
angular-oauth2-oidc.js:1184 TypeError: Cannot read property 'words' of undefined
core.js:15714 ERROR Error: Uncaught (in promise): TypeError: Cannot read property 'words' of undefined

I think that that the validateAtHash method in the ValidationHandler should not be called if requestAccessToken is set to false.

For now I simply extended the JwksValidationHandler and override validateAtHash:

import {JwksValidationHandler, ValidationParams} from 'angular-oauth2-oidc';

/**
 * Override the validateAtHash method as we don't request/use the access_token
 */
export class NoAccessTokenValidationHandler extends JwksValidationHandler {
    validateAtHash(validationParams: ValidationParams): Promise<boolean> {
        return Promise.resolve(true);
    }
}

[manfredsteyer]

Forgot to close this. We’ve added this check a while ago.

[ddhille]

Sorry for answering this old thread, it’s still open. Maybe I can clarify things:

@orditeck I just ran into the same issue. Same configuration, no access_token. TypeError: Cannot read property 'words' of undefined.

Thoroughly debugged @manfredsteyer 's code; was wondering why the JwksValidationHandler is missing the jwks object though it has been loaded.

Facepalm: I initialized the JwksValidationHandler BEFORE the DiscoveryDocument has been loaded. This solved my issue:

this.oauthService.loadDiscoveryDocument(myfunnyurl).then(() => {
  this.oauthService.tokenValidationHandler = new JwksValidationHandler();
});

Adding error handling for this would be nice @manfredsteyer 😉

@coltonneil The NullValidationHandler is not a solution; you’re just skipping validation, right…?