question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

loadDiscoveryDocumentAndLogin() should be renamed to loadDiscoveryDocumentAndStartImplicitFlow()

See original GitHub issue

Current method name loadDiscoveryDocumentAndLogin() is quite confusing, because it does not actually call something similar to the tryLogin() method (like loadDiscoveryDocumentAndTryLogin() does), but instead it does something completely different - ie, it redirects the user to the auth server.

The similarity in the names of loadDiscoveryDocumentAndLogin() and loadDiscoveryDocumentAndTryLogin() is very confusing, because they actually do completely different stuff.

It would be great to make the names more clear.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:5 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
jeroenheijmanscommented, Aug 8, 2020

I think, with a year past, no real interaction or others chiming in here, and the level of breaking change this would be, we could close this issue. Don’t think we’ll be making this change/addition on any short term…

0reactions
Maximaximumcommented, Feb 22, 2019

The name change could be done in the major branch. The new version does not have to be released right away, it would be ok to do it whenever there are enough reasonable changes, but at least the name changes will be in the next major release.

Also, I don’t understand what’s the problem to mark some method names as deprecated. It will not force the old users to change a single letter in their code, but will allow the new users to use meaningful names.

Otherwise… well, to be honest, the current state of the library in terms of clearness and understandability (and documentation as well) is not excellent (at least). It can just stay this way, then one day probably a better library appears, and everyone will simply move to using that one. Or, it can be improved.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Manually Skipping Login Form - angular-oauth2-oidc
First, try to use the loadDiscoveryDocumentAndLogin method instead of loadDiscoveryDocumentAndTryLogin . If you need more control, the following could be ...
Read more >
Part 3 - A responsive Angular app with OpenId Connect
When the loadDiscoveryDocumentAndLogin() operation is called, the OauthService will: Redirect the user to the Auth0 login page where the user's credentials ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found