question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

getDetails method in ERC721Standard and ERC1155Standard classes should return image/description instead of TokenURI

See original GitHub issue

The getDetails methods for ERC721Standard and ERC1155Standard currently fetch and return a tokenURI. Ideally they would fetch the tokenURI and then use it to fetch other more useful details like image name and description (possibly more) as we do in the getCollectibleInformationFromTokenURI method of the CollectiblesController.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
adonesky1commented, Feb 14, 2022

re data uri: I mean something like data:application/json;base64,ew0KICAgICJ…

ah yes we should have some logic to set this as its own field if the tokenURI is in this format

0reactions
wachuneicommented, Feb 14, 2022

re ipfs: cool 👍 re data uri: I mean something like data:application/json;base64,ew0KICAgICJ...

Read more comments on GitHub >

github_iconTop Results From Across the Web

Jumping into Solidity — The ERC721 Standard (Part 6)
The tokenURI function takes a tokenId as its only argument, and returns a URI which points to metadata about that specific token. Depending...
Read more >
ERC 721 - OpenZeppelin Docs
Imagine sending an in-game item to an exchange address that can't send it back! ... Internal function to set the token URI for...
Read more >
How to get metadata from ERC721 - Ethereum Stack Exchange
If a token contract properly implements the ERC721 Standard and the ERC721Metadata extension, it will always implement the function
Read more >
EIP-1155: Multi Token Standard
This standard outlines a smart contract interface that can represent any number of fungible and non-fungible token types. Existing standards ...
Read more >
Metadata Standards - OpenSea Developer Documentation
The tokenURI function in your ERC721 or the uri function in your ERC1155 contract should return an HTTP or IPFS URL. When queried,...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found