Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Replace Infura blacklist endpoint

See original GitHub issue

The https://api.infura.io/v2/blacklist endpoint is just a proxy of https://raw.githubusercontent.com/409H/EtherAddressLookup/master/blacklists/domains.json and https://raw.githubusercontent.com/MetaMask/eth-phishing-detect/master/src/config.json. We should request these files from GitHub directly to reduce our Infura traffic.

Issue Analytics

State:
Created 3 years ago
Reactions:3
Comments:13 (13 by maintainers)

Top GitHub Comments

1reaction

whymarrhcommented, Jun 16, 2020

We should be able to patch this via #244

1reaction

whymarrhcommented, May 6, 2020

That’s unfortunate. It does still have an ETag though, so we can at least ensure we don’t waste bandwidth when nothing changed.

Interesting, sending If-None-Match works via cURL:

curl -i 'https://raw.githubusercontent.com/MetaMask/eth-phishing-detect/master/src/config.json' \
  -H 'Connection: keep-alive' \
  -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.138 Safari/537.36' \
  -H 'Accept: */*' \
  -H 'Sec-Fetch-Site: none' \
  -H 'Sec-Fetch-Mode: cors' \
  -H 'Sec-Fetch-Dest: empty' \
  -H 'Accept-Language: en-US,en;q=0.9' \
  -H 'If-None-Match: W/"a05d16ca5ad05fef6b1c776695c0957a3080ac7c7b56c7b1d371d1a24b3055ed"' \
  --compressed

HTTP/1.1 304 Not Modified
Connection: keep-alive
Date: Wed, 06 May 2020 23:05:14 GMT
Via: 1.1 varnish
Cache-Control: max-age=300
ETag: W/"a05d16ca5ad05fef6b1c776695c0957a3080ac7c7b56c7b1d371d1a24b3055ed"
X-Served-By: cache-lga21969-LGA
X-Cache: HIT
X-Cache-Hits: 1
X-Timer: S1588806315.658028,VS0,VE91
Vary: Authorization,Accept-Encoding
Access-Control-Allow-Origin: *
X-Fastly-Request-ID: 3c9fecc3996e1215f9b5ef2dcd2694210ac88a2c
Expires: Wed, 06 May 2020 23:10:14 GMT
Source-Age: 0

But not via fetch. 🤔

I’m seeing the If-None-Match header being sent but the browser getting a 200 from the server instead of a 304. Can you confirm that the browser sees a 304?