question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Our default iframe ping timeouts may be too low

See original GitHub issue

Describe the bug

When scanning child iframes, our extension has to wait for a response from each frame. We have to balance two possibilities:

  • Analysis or messaging inside the child frame may be slow, so we need to wait long enough for a response. Giving up too early means we lose results.
  • The child frame may be entirely unresponsive; perhaps messaging is disabled altogether. Waiting too long means our users get confused because the spinning circle goes forever.

We need to pick the right timeout values so that we can scan as many websites as possible without waiting so long that users get annoyed when child frames are unresponsive.

There are two places where we currently wait for a response:

We have encountered a website on our support channel that requires a higher timeout. No matter what, we should notify the user that their iframe wasn’t scanned (tracked separately in #6128).

But this issue tracks whether we should also change our default timeouts.

To Reproduce Steps to reproduce the behavior:

  1. Go to this demo page
  2. Check the “delay propagation” checkbox
  3. Scan the website with AI-Web
  4. Notice we find no issues in the child iframe (we should, the input is empty)

Expected behavior

We have a few options:

  • Accept a higher ping timeout. In local testing on my computer, increasing the timeouts to 1000ms allows us to scan this website. However, different environments will have different performance - it’s possible that even 1000ms is too low for some setups.
  • Allow the end-user to configure the ping timeout from their extension. It could be a developer setting.
  • Leave things as they are

Context (please complete the following information)

  • AI-Web Version & Environment: 2.35 prod

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:9 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
ferBonnincommented, Nov 15, 2022

@shanisebarona assigning to you per draft PR 🙂

0reactions
msftbot[bot]commented, Nov 27, 2022

This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for contributing to Accessibility Insights!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Extended ping time out after 20 counts - Cisco Community
Iam pinging a remote notes server from my desktop. after successful 20-25 counts, it time outs for 1 or 2 times, then it...
Read more >
configurable HTTP/2 PING timeouts in HttpClient · Issue #31198
So I would like to request a new method in HttpClient class to support sending Http/2 pings or even better a kind of...
Read more >
How do I resolve a "request timed out" when pinging? - Quora
The request timed out error message means that the host you're pinging might be: 1. down or unreachable (e.g. because it's on a...
Read more >
timeout when ping target with 85 bytes - Microsoft Q&A
When I ping it from Internet with default 32 bytes, it is okay. But time out when using 85 or more bytes. How...
Read more >
Why does 'ping' returns 'request timed out' for some hosts?
ICMP blindly dispatches a frame to the destination host and waits for a few seconds if something comes back. – sinni800. May 16,...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found