question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

did_rename doesn't fire when only new extension matches filter

See original GitHub issue

It appears that in the case when a server has registered for the did_rename, and a FileOperationRegistrationOptions, with a filter:"**/*.txt" when the client renames a file from e.g. foo to foo.txt, no did_rename (and for completeness no did_create) event ever gets sent to the server.

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:9 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
dbaeumercommented, Mar 29, 2022

@DanTup good question. I will have a look.

In general, I think that the rename should only match the old URI. That is the resource that got renamed. Matching the new name should only happen on opt in, if we want to support it at all.

0reactions
dbaeumercommented, Mar 31, 2022

The idea of DidRename is nor for tracking purpose. If is to fix source code in cases where the file name must match a program symbol name (like in Java).

Read more comments on GitHub >

github_iconTop Results From Across the Web

pathPattern to match file extension does not work if a period ...
working like it does in a regular expression, where the * match is greedy and will match as many characters as possible.
Read more >
Semantic highlighting does not work if registered after file is ...
Testing microsoft/vscode-jupyter#8026 In a new window, Open a Python file (or have the Python file already opened when you reload) The ...
Read more >
Language Server Protocol Specification - 3.17
This document describes the 3.17.x version of the language server protocol. An implementation for node of the 3.17.x version of the protocol can...
Read more >
Cannot Start VIrtual Machine - VMware Communities
Hi,. Try to close VMware Workstation completely and check that there are no files with the extension ".lck" in the virtual machine folder,...
Read more >
How-To #4: Delete Empty Folders in SharePoint Document ...
Once the flow is in Edit mode, click on + New step to add the first ... This action will be used to...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found