Missing features in MetaModel

From https://github.com/microsoft/language-server-protocol/issues/67#issuecomment-1127746895

• TraceValue has “compact” in meta model but not in published spec
• NotebookDocumentSyncClientCapabilities has executionSummarySupport in meta model but not in published spec
• PrepareRenameParams might be missing WorkDoneProgressParams as a base in published spec? (it’s in meta model)
• In meta model, InitializeParams extends WorkspaceFoldersInitializeParams which does not mark workspaceFolders as optional (only nullable), but in the TS spec, it’s both optional (?) and nullable: workspaceFolders?: WorkspaceFolder[] | null;
• Documentation is missing for quite a few things (it’s in source TS, but missing in meta model):
  • CodeAction.disabled.reason (“Human readable description of why the code action is currently disabled.”)
  • completionItem.commitCharactersSupport (“Client supports commit characters on a completion item.”)
  • CompletionTriggerKind (“How a completion was triggered”)
  • Many (all?) enums (eg.: CodeActionKind.Empty, CodeActionTriggerKind.Automatic)

I opened https://github.com/microsoft/vscode-languageserver-node/pull/945 to address some of the typos and truncated docs (I don’t believe it addresses any of the above though).

[dbaeumer]

@DanTup no it is not LSP any. It is basically an object literal with no properties. We did this sine we expect properties to be added which is easier if a object literal is already specified.

[dbaeumer]

Fixed here: https://github.com/microsoft/vscode-languageserver-node/pull/987