Open in Windows Terminal doesn't open in the correct folder when Windows Terminal is already open

Issue Type: Bug

To reproduce:

1. specify settings

{
    "terminal.explorerKind": "external",
    "terminal.external.windowsExec": "wt"
}

1. add a folder to the workspace (FWIW I used $HOME/Downloads)
2. open Windows Terminal
3. right-click a file and choose Open in Windows Terminal
4. a new tab is opened in C:\Windows\System32 instead of the expected folder ($HOME/Downloads in this case)

VS Code version: Code - Insiders 1.67.0-insider (a9288be67bab4e9c4dbe62207f01fafc2bdaadcb, 2022-04-15T05:16:11.219Z) OS version: Windows_NT x64 10.0.22000 Restricted Mode: No

Extensions: none

A/B Experiments

vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30422396
pythontb:30258533
pythonvspyt551:30291412
pythonptprofiler:30281269
vsdfh931cf:30280410
vshan820:30294714
pythondataviewer:30285072
vscod805:30301674
pythonvspyt200:30323110
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30404738
wslgetstarted:30449409
pythonvspyt640:30438691
vscscmwlcmt:30465136
pynewfile477:30451556

[zadjii-msft]

Okay, I know this doesn’t sound like it, but I think we’re tracking this in https://github.com/microsoft/terminal/issues/5506.

That’s the one I’m generally using for “when a commandline is given to an existing window, make sure to evaluate it’s startingDirectory relative to the CWD the commandline was already run in”.

[zadjii-msft]

Hmm okay I see what’s going on here. You’re spawning wt -d . in c:\whatever. When this works, it’s because Terminal is evaluating . as relative to the Terminal’s own CWD, which is c:\whatever.

If you’ve got useAnyExisting set, then that commandline will get handed off to the existing Terminal window. That window probably has a different CWD, so . won’t work right.

I know we’re tracking this in a couple places on our repo, I’ll find them after lunch.