question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Disable option to Start Review when no comment text

See original GitHub issue
  • Extension version: 1.79.0
  • VSCode Version: 1.33.0
  • OS: macOS

Steps to Reproduce:

  1. Go to leave a comment on a line
  2. Observe that the comment box has the Start Review option enabled by default. Screen Shot 2019-03-26 at 2 17 51 PM

Solution: This option should be disabled until some text is actually entered in the comment box.

Discovered when testing for: https://github.com/Microsoft/vscode/issues/71103

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:10 (10 by maintainers)

github_iconTop GitHub Comments

1reaction
rebornixcommented, Mar 29, 2019

It sounds like a good feature to me but if you think we’d better avoid that, we can throw an error or show a notification when users try to create a review without comments. This way we don’t need to wait for any vscode side code change, which is already late at this point.

1reaction
RMacfarlanecommented, Mar 28, 2019

Yeah, that’s right.

So instead of having the API be additionalAcceptInputCommands: Command[];, it would be

additionalAcceptInputCommands: [{
	command: Command;
	disableWhenEmpty: boolean;
}]
Read more comments on GitHub >

github_iconTop Results From Across the Web

Using modern comments in Word - Microsoft Support
Click New Comment in the Review tab. In the Comments pane, click New. Click New in the Comments pane. Press Ctrl + Alt...
Read more >
How to Hide Comments in Word (or Display Them)
Click the Review tab in the Ribbon. In the Tracking group, click Show Markup. A drop-down menu appears. Select Comments to deselect comments....
Read more >
How to Disable Comments on Your Facebook Wall/Profile ...
Click on the dropdown arrow at the top right and select Settings & Privacy. Click on Settings. Select Profile and Tagging in the...
Read more >
How to Disable Comments in WordPress (Step by Step)
1. Stop comments on all future posts (and pages) - Uncheck the option allow people to post comments on articles; You can also...
Read more >
How to Completely Disable Comments in WordPress (Ultimate ...
Select Do not allow from the comments dropdown box and click on Update. This will disable comments on all your selected posts.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found