question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Not clear on how to finish review from pending review comment

See original GitHub issue

I found it confusing to figure out how to finish a review after leaving a comment that was pending. I don’t think this is a bug, rather an enhancement that would improve the user experience.

  • Extension version: 1.79.0
  • VSCode Version: 1.33.0
  • OS: macOS

Steps to Reproduce:

  1. Comment on a line
  2. Select to Start Review
  3. See comment is pending
Screen Shot 2019-03-26 at 2 12 59 PM
  1. Clicking Reply... on the comment will expand the options shown below:
Screen Shot 2019-03-26 at 2 13 07 PM

Solution: Is it possible to show these options without having to click into the Reply field?

Discovered when testing for: https://github.com/Microsoft/vscode/issues/71103

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:13
  • Comments:5 (2 by maintainers)

github_iconTop GitHub Comments

3reactions
clairrosscommented, May 6, 2021

+1, Switching the Comment button to be a Finish Review button option would be inline with what I had expected the functionality to be. Hope this is in the backlog!

2reactions
blackmadcommented, Jan 13, 2021

+1 to confusing/frustrating (but otherwise this plugin is amazing and I feel silly for not having started using it sooner)

+1 to could be a command palette entry, could also be a button on the description/overview page

Read more comments on GitHub >

github_iconTop Results From Across the Web

deal with pending comments on lines that get changed before ...
Reviewer writes a pending comment on a code line of a merge request; A few moments/minutes/days pass; A commit is pushed that changes...
Read more >
Understand what happens to your Business Profile edits
If your edits aren't published, you could find the message: “Your edit is pending. It usually takes up to 10 minutes to be...
Read more >
How to batch GitHub PR post-review comments notifications?
Is it possible to make pending such post-review comments and submit them as a single notification? If not, I will submit a feature...
Read more >
Reviewing Your Manuscript Q&A - MDPI Blog
Make sure to leave a comment if your question isn't answered here! ... My manuscript is under pending review and i have not...
Read more >
Completing Review - Documentation - Devart
Once they add comments to the review and have nothing else to add, the next step is to complete a review. The reviewer...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found