Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Safari: Change popup blocker workaround to use a real link to open normaly

See original GitHub issue

Cmd + Click on a link in a markdown file opens new window in Safari. When I Cmd + Click a link on a webpage, it opens in a new tab. Can we align with that? (I guess this is env.openExternal()'s behavior.)

Version: 1.74.0-insider Commit: ef415578d1b1019db585718968a303eeca4b8979 User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.1 Safari/605.1.15 Embedder: github.dev

Issue Analytics

State:
Created 10 months ago
Comments:7 (7 by maintainers)

Top GitHub Comments

1reaction

alexdimacommented, Dec 12, 2022

https://github.com/microsoft/vscode/pull/136383 introduced windowOpenPopup, it looks like it has something to do with the auth flow, so I assume only trusted links should be opened using that.

1reaction

bpaserocommented, Dec 12, 2022

@alexdima super nice analysis and I think as such worthy to keep open as issue, even though the change will be ugly: Dialog is a very generic component and Button is a part of it with well established accessibility rules and API, so the link workaround is ugly, but necessary in this case, I agree. On top of that, we seem to have logic to sometimes call into windowOpenPopup if we trust the link?

An alternative would be to somehow embed the link in the text of the dialog, but it looks like we do not allow that (tried with Markdown syntax).

Top Results From Across the Web

Allow or block pop-ups in Safari on Mac - Apple Support

Allow or block pop-ups on one website · In the Safari app on your Mac, go to the website. · Choose Safari >...

How to Allow & Block Pop-Ups in Safari | Mac & iPhone - Avast

Open Settings and tap Safari. highlighting Safari in Apple mobile Settings · Next to Block Pop-ups, toggle the button on. Highlighting the 'Block...

How to Allow or Block Pop-Ups in Safari - AVG

Here's how to stop all pop-ups on Mac using the Safari pop-up blocker: Open the Safari browser and click Preferences under the Safari...

Turn Off Pop-Up Blocking in Safari - JMU

Uncheck the checkbox "Block pop-up windows". Close the Preferences window. From your tablet or iPhone: Open the Settings app on your device; Select...

Bypass popup blocker on window.open when JQuery event ...

Popup blockers will typically only allow window.open if used during the processing of a user event (like a click). In your case, you're ......