Ability to tweak multi threaded image loading
See original GitHub issueFirst of all, thanks for this great library!
I’m using TileView to display large paintings. The tiles are downloaded from the internet. I have setShouldRenderWhilePanning
set to true
because it offers the best user experience. Sometimes while flinging the animation gets jaggy.
I feel this might be because there are multiple thread working on downloading the images. Maybe when using a single thread, the tiles might be loaded a little less fast, but would also have less overhead and allow more resources for Android to smoothly show the animations.
Right now the TileRenderPoolExecutor
is tightly coupled with the TileView, it would be great if there was some way to tweak the TileRenderPoolExecutor
or add an abstraction layer (interface) for the class in charge of loading the tile-set (with TileRenderPoolExecutor
as the default implementation)
Additionally I use TileView inside a ViewPager
which allows the user to browse through an art collection. Each individual TileView
creates and stops a PoolExecutor
which also adds overhead. It would make more sense to share a PoolExecutor
between TileView
’s
What are your thoughts on this? Of course I’m willing to help by creating a pull request 😃
Issue Analytics
- State:
- Created 7 years ago
- Comments:26 (14 by maintainers)
I can confirm this has a huge impact on performance, even for local tiles! No more stutter even in worse conditions. This is getting better and better 🍡
You can close this issue, maybe I’ll make a pullrequest for DI-ing the executor because I still feel this will reduce overhead in a viewpager. But no need to keep this issue open for that IMO