Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

MinimumScaleMode.Fit and coordinates

See original GitHub issue

Hey, thanks to @tsuijten and @peterLaurence PR #318 introduced the MinimumScaleMode.Fit mode adding whitespaces when totally zoomed out. However, this broke the coordinates of tap events. A short example: Lets say I have an image of 1000 width * 500 height and set MinimumScaleMode.FIT. Zoomed totally in at 1.0 and tapping the lower right I get x,y of 1000,500. Fine. Zooming out it adds the whitespaces and centres the image, also fine. However, if I tap the lower right now I get x,y of something like 1000,2500 because the added whitespace. This offset is calculated in ZoomPanLayout.onLayout() with translateX and translateY and should be used to offset the MotionEvent the onTouchEvent() gets.

Issue Analytics

State:
Created 7 years ago
Comments:23 (6 by maintainers)

Top GitHub Comments

2reactions

p-lrcommented, Aug 23, 2016

I found the fix. setClipChildren( false ); has to be added in MarkerLayout constructor too. In that particular case, the MarkerLayout was clipping its child view.

1reaction

moagriuscommented, Aug 23, 2016

2.2.1 is out