question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

version.json has wrong date?

See original GitHub issue

Steps to reproduce

Go to https://www.mtgjson.com/files/version.json

As of today, you will get: {"date": "2019-11-23", "pricesDate": "2019-11-23", "version": "4.6.0+20191123"}

What is expected?

There is a date and a pricesDate. The last one is obvious and correct as it always updates every day.

The first one though is supposed to be the date when card data got updated the last time. In this case, I would expect it to be the date of the 4.6.0 release which would be 2019-10-28 instead. Since then only prices got changed every day. No new cards, no typos fixed, no new fields etc.

What is actually happening?

date gets updated every time, the same as pricesDate. While that used to be correct with the old update pattern, this changed with the availability of prices and daily builds to refresh them. Not every build of the same release to update card prices doesn’t mean the release changed or there are new cards, problems fixes or structural changes to the mtgjson file.


Maybe the wording should change: date or releaseDate: date when the version was released pricesUpdate: holds the date of the daily new build Or remove pricesDate completely as the version includes it already…

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:11 (10 by maintainers)

github_iconTop GitHub Comments

1reaction
omfgitsmarkcommented, Dec 7, 2019

Fixed and tested. It will be correct in tomorrow’s price build.

0reactions
tooommcommented, Jan 14, 2020

As of 13th of janaury: {"date": "2019-12-01", "pricesDate": "2020-01-08", "version": "4.6.1+20200108"} Where is that “date” coming from… we are back to https://github.com/mtgjson/mtgjson/issues/487#issuecomment-562900795 again.

How can the “date” (=“When all files were last completely built.”) be older than the last version release? I expect that on a new version release a new build is happening, too… so either the date is wrong in the version field (should be 2019-12-04), or the release date is wrong in the changelog on the webpage (should be 2019-12-01?). See changelog for 4.6.1


Edit: Ctrl+F5 finally brought me an update for version.json in between, took a while. While “pricesDate” seems ok, the reported problem persists and the “date” field still shows “2019-12-01”: {"date": "2019-12-01", "pricesDate": "2020-01-13", "version": "4.6.1+20200113"}

Read more comments on GitHub >

github_iconTop Results From Across the Web

Json date being serialized to wrong format - Stack Overflow
In my development environment, when I post to the method, the date comes through fine, the model is valid and the date is...
Read more >
Converting to JSON and back gives wrong date #1365 - GitHub
My timezone is MST (-7). It looks like has been fixed. I was using version 2.0.0.0. I just tried it in 2.4.0 and...
Read more >
A wrong date is obtained after calling the JSON.stringify function
Dear sir or madam, I am currently working with a date picker in an angularjs application. When I set the date to the:...
Read more >
JSON date handling changed in latest release? - Telerik
In version v2011.3.1413, I had dates in a JSON data structure ... If change the datasource schema model to string, then sorting works...
Read more >
Migrate from Newtonsoft.Json to System.Text.Json - .NET
Learn how to migrate from Newtonsoft.Json to System.Text.Json. Includes sample code.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found