latest build (as per readme) features an old version of animation-mixer that does not match docs / lacks startFrame
See original GitHub issueThe version of animation mixer that one finds at https://cdn.jsdelivr.net/gh/donmccurdy/aframe-extras@v6.1.1/dist/aframe-extras.js
does not have a startFrame
property, as you see in the repo’s version of that component and read about in the readme for that component.
I ended up just copying the component out myself to get it working in a pinch, but I’m not sure if that’s just been recently added and a new release is pending or if some other problem is happening with the dist generation.
You can see this by just going to https://cdn.jsdelivr.net/gh/donmccurdy/aframe-extras@v6.1.1/dist/aframe-extras.js and doing ctrl+f animation-mixer
and looking there, and comparing the schema there with the schema at https://github.com/n5ro/aframe-extras/blob/master/src/loaders/animation-mixer.js.
Issue Analytics
- State:
- Created 2 years ago
- Reactions:1
- Comments:7 (5 by maintainers)
I don’t know I was thinking, with a PR, of looking to at least add the missing ‘startFrame’ and ‘clampWhenFinished’ code, why would we update the readme at this point? but I would need perhaps to look at all the other updates to the code, and perhaps also this update should be done as a version update, on my local system, with npm, while updating everything else, and then updating the github, instead of going the patchwork route of individual lines of code being edited in a PR. I think I need to allocate more of my time to looking into this first a lot more to really answer your question. I think also that I should just change all the demos to use Ammo in Aframe Physics System for now. Because I will need to spend extra time testing the Cannon updates that I have planned.
Kyle since you spotted this first do you want to send a PR. I should make an effort to approve it quickly.