a potential NPE in DmgServer.java

Describe the bug

1. In DmgFileReader.java (GPL/DMG/src/dmg/java/mobiledevices/dmg/reader/DmgFileReader.java), line 256 function getInfo returns null when path is null.

2. In DmgServer.java (GPL/DMG/src/dmg/java/mobiledevices/dmg/server/DmgServer.java) line 106 List<String> infoList = dmgFileReader.getInfo(path); will assign infoList null.

3. The expression infoList.size() in line 107 will NPE.

To Reproduce See above

Expected behavior N/A

Screenshots N/A

Attachments N/A

Environment (please complete the following information): N/A

Additional context N/A

[mumbel]

As you say, you’re running static analysis and hoping others will validate your ‘findings’. Where is the stack trace, whats the user interaction that causes this, what is the input to cause this, do you have binary to load or a script or maybe a java test class, anything?

[HermioneSW]

Whatever I have does not prevent you from answering the question so here I go again. If the person is so confident path can not be null why not simply do

public List<String> getInfo( String path ) {
    DmgInfoGenerator info = new DmgInfoGenerator( this, path, parser );			
    return info.getInformation( );
}

I’d be very happy to hear your lecture on why that is the case or anything else you have to say. By the way feel free to close the issue as I don’t give a damn how great this codebase is written.